search

mrc-ide / helios

Simulating far UVC for pathogen control
https://mrc-ide.github.io/helios/
Other
5 stars 0 forks source link

Consider different file location for `blueprint_demo_May_raw_outputs` #82

Closed athowes closed 5 months ago

athowes commented 5 months ago

Currently the files blueprint_demo_May_raw_outputs are a folder within data/. I think this means that the package will try to make them available to users. I think that we should either:

  1. Put these files somewhere else
  2. Document the files

I'd probably suggest 1. as I don't think that we particularly want package users to have easy access to these.

cwhittaker1000 commented 5 months ago

@athowes completely agreed and nice spot. Happy for you to put the files somewhere else (perhaps in the inst folder?) - feel free to create a PR and then just merge, no need for review.

cwhittaker1000 commented 5 months ago

Closing via https://github.com/mrc-ide/helios/commit/922e41fde6fa1144bbe3a651a6e4dc31e1109be8

athowes commented 5 months ago

@cwhittaker1000 suggest using things like "2024-05" (at start) rather than "May2024" (at end). Better for sorting