Closed slwu89 closed 3 years ago
Merging #157 (ecb8275) into dev (922dd3b) will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #157 +/- ##
==========================================
+ Coverage 95.92% 95.95% +0.03%
==========================================
Files 26 26
Lines 1201 1210 +9
==========================================
+ Hits 1152 1161 +9
Misses 49 49
Impacted Files | Coverage Δ | |
---|---|---|
R/bitset.R | 85.71% <100.00%> (+0.60%) |
:arrow_up: |
inst/include/IterableBitset.h | 98.52% <100.00%> (+0.03%) |
:arrow_up: |
src/bitset.cpp | 98.21% <100.00%> (+0.06%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ffbf7c9...ecb8275. Read the comment docs.
@giovannic thanks for looking at this!
I am now entering the temple of small optimizations 🙇♂️ I decided to test 3 methods against each other. "for" is the existing for loop, but now assigning 0x0ULL literal to each element of the vector rather than doing &=
. "fill" is using std:fill
on the bitmap. "alloc" uses the assignment operator with a new vector ctor as your suggested. The results of checking speed are....not what I expected. It looks like the for loop is faster above 1e6 elements.
wow, loop go brrr
tiny PR, just implements $clear() for bitsets to zero out all set bits and tests it.