Closed plietar closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.13%. Comparing base (
c9cdee3
) to head (b99d893
). Report is 21 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Calling
all.equal
(or equivalentlyexpect_equal
) on bitsets has never worked correctly. For some reason, externalptr always compare as equal, thus, under the R6 implementation, any bitset with the same max size was treated as equal.With the recent switch to a named list and bitsets would sometimes be considered different, even where their contents were the same. More precisely, the arguments of
Bitset$new
now happen to be captured by all of the methods' environments and were being included in the comparison. A bitset created withnew(size=N)
would always be different compared to a bitset created withnew(from=ptr)
.malariasimulation has some tests that use
mockery::expect_args
to compare bitset arguments, and these tests are now broken by the new individual version.