search

mrc-ide / leapfrog

Multistate population projection model for demographic estimation.
Other
2 stars 5 forks source link

Dev add deaths #16

Closed mwalte10 closed 2 years ago

mwalte10 commented 2 years ago

Passing tests but would be great if you could look at the absolute and relative cutoffs I have set in the helper-checkfunctions file

mwalte10 commented 2 years ago

Also since this is now aligning I think the issue was just where births were being done, I moved it below all aging and natural deaths for tot pop and people with HIV and now they align

jeffeaton commented 2 years ago

Also since this is now aligning I think the issue was just where births were being done, I moved it below all aging and natural deaths for tot pop and people with HIV and now they align

Can you clarify: is this a change to code you had added in earlier commits (#14) or is this moving around the existing demography code?

mwalte10 commented 2 years ago

Sorry I think I set these PRs up in a confusing way, pr 16 is now the most up to date and has two changes from the current master:

I closed the other two PRs and merged the HIV p onto this branch. Looks like its failing so will check that then push again!