vignette typos from AFIDEP work - Githubissues

mrc-ide / naomi

Naomi model for subnational HIV estimation

https://mrc-ide.github.io/naomi

Other

9 stars 9 forks source link

vignette typos from AFIDEP work #420

Open jeffeaton opened 9 months ago

jeffeaton commented 9 months ago

Some typos and out-of-date elements in example vignette from review with AFIDEP (thanks @mcewenkhundi):

[ ] second appearance of artnum_quarter_id_t1 should be _t2 https://github.com/mrc-ide/naomi/blob/2a4512863d6e9be66e400e80b234c9429fd298ac/vignettes_src/model-workflow.R#L93
[ ] Referring to ANC quarter IDs is out of date. These are now provided as full year data. https://github.com/mrc-ide/naomi/blob/2a4512863d6e9be66e400e80b234c9429fd298ac/vignettes_src/model-workflow.R#L97-L99
[ ] Plot does not select the calendar_quarter, so it is probably overplotting all quarters https://github.com/mrc-ide/naomi/blob/2a4512863d6e9be66e400e80b234c9429fd298ac/vignettes_src/model-workflow.R#L247-L258