search

mrc-ide / odin.dust

Compile odin to dust
https://mrc-ide.github.io/odin.dust
Other
3 stars 1 forks source link

Use correct NA value for user handling #101

Closed richfitz closed 2 years ago

richfitz commented 2 years ago

As found by @annecori, we wrote code that performed poorly on an ARM Mac.

The testing is not ideal, but should at least prevent regressions. There's no obvious way of triggering this without running on an M1 which is not really possible in a CI environment. Fix confirmed on Anne's machine.

codecov[bot] commented 2 years ago

Codecov Report

Merging #101 (8d3faae) into master (5c0f10b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          971       972    +1     
=========================================
+ Hits           971       972    +1
Impacted Files Coverage Δ
R/generate_dust_equation.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c0f10b...8d3faae. Read the comment docs.