search

mrc-ide / odin.dust

Compile odin to dust
https://mrc-ide.github.io/odin.dust
Other
3 stars 1 forks source link

Support for sharing constant memory between particles #46

Closed richfitz closed 3 years ago

richfitz commented 3 years ago

Support for sharing constant memory between particles. Creates a shared_ptr to a const struct that all particles can read from; see https://github.com/mrc-ide/dust/pull/124 for the approach

Merge after ~#44 as this PR builds on it, and after~ https://github.com/mrc-ide/odin/pull/215 is merged (update the DESCRIPTION to remove the branch pin)

This is somewhat tedious to benchmark, but at least for sircovid this makes no difference at all with identical timings. I'd expect memory usage to be slightly lower, but because we don't go through R's allocator bench is not reporting sensible numbers.

Still, hopefully this will prove useful for the GPU work, at least as a proof-of-concept

Fixes #45

codecov[bot] commented 3 years ago

Codecov Report

Merging #46 (1d6036d) into master (216fc57) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #46   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          507       533   +26     
=========================================
+ Hits           507       533   +26
Impacted Files Coverage Δ
R/generate_dust.R 100.00% <100.00%> (ø)
R/generate_dust_sexp.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 216fc57...1d6036d. Read the comment docs.