search

mrc-ide / odin.dust

Compile odin to dust
https://mrc-ide.github.io/odin.dust
Other
3 stars 1 forks source link

Basic modulo #53

Closed richfitz closed 3 years ago

richfitz commented 3 years ago

Implements a %% b by translating to std::fmod(a, b)

We might want to extend this to be R's fancy modulo which differs for negative values but that's not needed right now and runs into some issues with needing to change the order of includes

Fixes #52

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (a0a7e69) into master (618e517) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          533       533           
=========================================
  Hits           533       533

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 618e517...a0a7e69. Read the comment docs.

weshinsley commented 3 years ago

Looks good to me - and it looks pleasantly simple to add the new functionality.