Closed richfitz closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
938cb5d
) 100.00% compared to head (e069323
) 100.00%.:exclamation: Current head e069323 differs from pull request most recent head 17925a0. Consider uploading reports for the commit 17925a0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR provides parse support for the new compare syntax (see https://github.com/mrc-ide/odin.dust/issues/130 and the corresponding PR https://github.com/mrc-ide/odin.dust/issues/131). I doubt we'll ever support this in O.G. odin, but we will eventually in the js version which uses a dust-like target.
Here, we just try and wrangle the input and do as little validation as possible. One nice thing about this approach is that all the bits for checking unused variables etc come along for free.
Note that this is intentionally undocumented; we'll document it properly in odin.dust when supported, and it really will just represent a ghost feature in odin
Alex; just adding you here as a FYI, but any comments very welcome
A reminder of the order of PRs: