mrc-ide / orderly2

https://mrc-ide.github.io/orderly2/
Other
7 stars 2 forks source link

`draft/` folder feels like a misnomer — it's just a `failed/` folder? #157

Open jeffeaton opened 3 months ago

jeffeaton commented 3 months ago

Now with orderly_run() automatically committing completed runs to archive/, the draft/ folder feels misnamed. What is left in there are reports that have failed.

Personally, I sort of miss the old [draft] -> commit to [archive] workflow. Is there scope to bring that back as an option? (Maybe an arg orderly_run(..., archive = FALSE)?)

Otherwise, perhaps rename the folder to something reflecting what lives in there?

richfitz commented 3 months ago

This is where things are run though, so they literally are drafts until successful. Unfortunately drafts is one of the things that users of orderly1 will have to unlearn: see https://mrc-ide.github.io/orderly2/reference/orderly_run.html#equivalence-to-the-old-use-draft-option for some docs on this.

The big issue we get is if you have done a run into draft, people inevitably ended up wanting to use it for things, so things in drafts were sort of both draft and also archive and there was lots of code duplicated doing sort of the same thing, with no clear workflow.

Now, you should be able to delete whatever you want, so the cost of running something is much lower

jeffeaton commented 2 months ago

Thanks, sounds good. I think more directive instructions on 'how to correctly delete' will also help lower the bar on this — just added an issue suggesting on that: #161.