search

mrc-ide / orderly2

https://mrc-ide.github.io/orderly2/
Other
7 stars 2 forks source link

Replace uses of `fs::file_copy` with `file.copy`. #165

Closed plietar closed 2 months ago

plietar commented 2 months ago

Unfortunately fs::file_copy has issues when working with read-only files on a Samba mounted file system. file.copy doesn't have the same problem. See mrc-5557 for more details.

This was tested manually and confirmed to work by running a basic report with an orderly_dependency call on a Samba mount. Unfortunately it is not something we can easily test for automatically.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.91%. Comparing base (07c1d31) to head (5ea0ceb). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #165 +/- ## =========================================== - Coverage 100.00% 99.91% -0.09% =========================================== Files 40 40 Lines 3699 3735 +36 =========================================== + Hits 3699 3732 +33 - Misses 0 3 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.