search

mrc-ide / orderly2

https://mrc-ide.github.io/orderly2/
Other
7 stars 2 forks source link

Improve handling of deleted implicit inputs. #171

Closed plietar closed 1 month ago

plietar commented 1 month ago

In implicit mode, orderly prints a message if some of the implicit inputs have been modified by the report. However the code to enumerate modified files did not properly handle files that have been deleted. When that happens, fs::file_info return NA in all the metadata columns.

We now detect these files and display a slightly different warning for it.

Cleaned up a bit of adjacent code: switch from handcrafted bullet points to using cli::cli_ul, fixed some tests which had used suppressMessages when they could have used orderly_run_quietly.

plietar commented 1 month ago

I'm kind of on the fence about whether this even deserves a warning at all. There's nothing really actionable the user can do other than not writing weird reports.