mrc-ide / rrq

:runner::runner::runner: Lightweight Redis queues
https://mrc-ide.github.io/rrq/
Other
24 stars 4 forks source link

Rename heartbeat_send_signal to heartbeat_kill #42

Closed richfitz closed 3 years ago

richfitz commented 3 years ago

Now that we don't use this for interrupting tasks anymore, this is a simpler interface to maintain.

Merge after #41 as it follows on

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (87fc60d) into mrc-2324 (fc1a95c) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 87fc60d differs from pull request most recent head cce14be. Consider uploading reports for the commit cce14be to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           mrc-2324       #42   +/-   ##
==========================================
  Coverage    100.00%   100.00%           
==========================================
  Files            21        21           
  Lines          1442      1467   +25     
==========================================
+ Hits           1442      1467   +25     
Impacted Files Coverage Δ
R/common.R 100.00% <ø> (ø)
R/worker.R 100.00% <ø> (ø)
R/bulk.R 100.00% <100.00%> (ø)
R/heartbeat_impl.R 100.00% <100.00%> (ø)
R/keys.R 100.00% <100.00%> (ø)
R/rrq_controller.R 100.00% <100.00%> (ø)
R/worker_run.R 100.00% <100.00%> (ø)
R/worker_runner.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 25a2c56...cce14be. Read the comment docs.