search

mrc-ide / rrq

:runner::runner::runner: Lightweight Redis queues
https://mrc-ide.github.io/rrq/
Other
24 stars 4 forks source link

mrc-2369: control over exported variables #43

Closed richfitz closed 3 years ago

richfitz commented 3 years ago

This PR adds support for explicitly listing variables copied over with an expression.

This is required to support future where the analysis of variables is already done, and the "user" in this case specifies name/value pairs needed for the remote calculation.

At the same time this tidies up some unneeded/unexposed complication in the expression analysis code

~Rebase on #39 once it's merged.~

codecov[bot] commented 3 years ago

Codecov Report

Merging #43 (19ee719) into master (50954e9) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 19ee719 differs from pull request most recent head 095af21. Consider uploading reports for the commit 095af21 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         1467      1465    -2     
=========================================
- Hits          1467      1465    -2
Impacted Files Coverage Δ
R/bulk.R 100.00% <100.00%> (ø)
R/expression.R 100.00% <100.00%> (ø)
R/rrq_controller.R 100.00% <100.00%> (ø)
R/utils_assert.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 50954e9...095af21. Read the comment docs.