search

mrc-ide / rrq

:runner::runner::runner: Lightweight Redis queues
https://mrc-ide.github.io/rrq/
Other
24 stars 4 forks source link

Use R6 constructors directly #53

Closed richfitz closed 3 years ago

richfitz commented 3 years ago

This PR removes the helper rrq_controller() function and instead uses the R6 constructor directly.

I've not added any compatibility helpers (unlike in https://github.com/mrc-ide/odin/pull/227) as the current user list is small enough that we can patch them up directly.

Once merged, update:

The spimalot PR will work with either version

codecov[bot] commented 3 years ago

Codecov Report

Merging #53 (7a31b20) into master (8abd470) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 7a31b20 differs from pull request most recent head 1cfddd5. Consider uploading reports for the commit 1cfddd5 to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##            master       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1699      1698    -1     
=========================================
- Hits          1699      1698    -1
Impacted Files Coverage Δ
R/envir.R 100.00% <ø> (ø)
R/heartbeat_impl.R 100.00% <ø> (ø)
R/rrq_controller.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8abd470...1cfddd5. Read the comment docs.