Closed richfitz closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
1b2367d
) 100.00% compared to head (f4a61c0
) 100.00%.:exclamation: Current head f4a61c0 differs from pull request most recent head 9d87e9a. Consider uploading reports for the commit 9d87e9a to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This Pr is a bit like tugging a loose string and has uncovered a few other nasty bits.
The aim is to allow a simple interface to error on task retrieval with
task_result
and friends and also the bulk functions (likelapply
). This is conceptually relatively easy by adding anerror = FALSE
argument to these functions, and throwing if the user passeserror = TRUE
and if any of the underling tasks error. This uncovered a few things:single
to the internal implementations oftasks_result
andtasks_wait
so they know if they were called in a scalar context or not (I also renamedtask_results
to tasks_result` as this was inconsistent)Things to do later (mrc-4090):
error
arg?