mrc-ide / rrq

:runner::runner::runner: Lightweight Redis queues
https://mrc-ide.github.io/rrq/
Other
24 stars 4 forks source link

Allow immediate task error #80

Closed richfitz closed 1 year ago

richfitz commented 1 year ago

This Pr is a bit like tugging a loose string and has uncovered a few other nasty bits.

The aim is to allow a simple interface to error on task retrieval with task_result and friends and also the bulk functions (like lapply). This is conceptually relatively easy by adding an error = FALSE argument to these functions, and throwing if the user passes error = TRUE and if any of the underling tasks error. This uncovered a few things:

Things to do later (mrc-4090):

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1b2367d) 100.00% compared to head (f4a61c0) 100.00%.

:exclamation: Current head f4a61c0 differs from pull request most recent head 9d87e9a. Consider uploading reports for the commit 9d87e9a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 27 28 +1 Lines 1726 1763 +37 ========================================= + Hits 1726 1763 +37 ``` | [Impacted Files](https://codecov.io/gh/mrc-ide/rrq/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide) | Coverage Δ | | |---|---|---| | [R/bulk.R](https://codecov.io/gh/mrc-ide/rrq/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui9idWxrLlI=) | `100.00% <100.00%> (ø)` | | | [R/errors.R](https://codecov.io/gh/mrc-ide/rrq/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui9lcnJvcnMuUg==) | `100.00% <100.00%> (ø)` | | | [R/format.R](https://codecov.io/gh/mrc-ide/rrq/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui9mb3JtYXQuUg==) | `100.00% <100.00%> (ø)` | | | [R/rrq\_controller.R](https://codecov.io/gh/mrc-ide/rrq/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui9ycnFfY29udHJvbGxlci5S) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.