mrc-ide / rrq

:runner::runner::runner: Lightweight Redis queues
https://mrc-ide.github.io/rrq/
Other
24 stars 4 forks source link

Tidy up worker run #95

Closed richfitz closed 1 year ago

richfitz commented 1 year ago

Things I noticed elsewhere but didn't want to put into other PRs, as we never use either the cancel key or the key_complete as pulled here. I've tidied up the "active task" to be just the task id, too.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (91aa1f5) 99.89% compared to head (fc415f5) 99.89%.

:exclamation: Current head fc415f5 differs from pull request most recent head f41d7d1. Consider uploading reports for the commit f41d7d1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #95 +/- ## ========================================== - Coverage 99.89% 99.89% -0.01% ========================================== Files 28 28 Lines 1973 1969 -4 ========================================== - Hits 1971 1967 -4 Misses 2 2 ``` | [Impacted Files](https://codecov.io/gh/mrc-ide/rrq/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide) | Coverage Δ | | |---|---|---| | [R/worker.R](https://codecov.io/gh/mrc-ide/rrq/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXIuUg==) | `100.00% <100.00%> (ø)` | | | [R/worker\_run.R](https://codecov.io/gh/mrc-ide/rrq/pull/95?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXJfcnVuLlI=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.