mrc-ide / rrq

:runner::runner::runner: Lightweight Redis queues
https://mrc-ide.github.io/rrq/
Other
24 stars 4 forks source link

Simpler worker creation #96

Closed richfitz closed 1 year ago

richfitz commented 1 year ago

Drops the old form, now everything goes through the configuration. I've changed quite a few defaults too - you could split this PR after the two first commits perhaps to reduce churn?

One thing I've not done here is to rename the default worker configuration from localhost to default, but I'd like to do that soon too

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 96.15% and project coverage change: -0.30 :warning:

Comparison is base (0c9542c) 99.95% compared to head (fec1ee5) 99.65%.

:exclamation: Current head fec1ee5 differs from pull request most recent head 68ab149. Consider uploading reports for the commit 68ab149 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #96 +/- ## ========================================== - Coverage 99.95% 99.65% -0.30% ========================================== Files 28 28 Lines 2014 2003 -11 ========================================== - Hits 2013 1996 -17 - Misses 1 7 +6 ``` | [Impacted Files](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide) | Coverage Δ | | |---|---|---| | [R/common.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui9jb21tb24uUg==) | `100.00% <ø> (ø)` | | | [R/worker\_runner.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXJfcnVubmVyLlI=) | `84.61% <0.00%> (-15.39%)` | :arrow_down: | | [R/worker\_config.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXJfY29uZmlnLlI=) | `94.87% <94.87%> (-5.13%)` | :arrow_down: | | [R/rrq\_controller.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui9ycnFfY29udHJvbGxlci5S) | `99.84% <100.00%> (-0.01%)` | :arrow_down: | | [R/worker.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXIuUg==) | `100.00% <100.00%> (ø)` | | | [R/worker\_messages.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXJfbWVzc2FnZXMuUg==) | `100.00% <100.00%> (ø)` | | | [R/worker\_run.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXJfcnVuLlI=) | `100.00% <100.00%> (ø)` | | | [R/worker\_spawn.R](https://app.codecov.io/gh/mrc-ide/rrq/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mrc-ide#diff-Ui93b3JrZXJfc3Bhd24uUg==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.