search

mrc-ide / safir

squire and friends individual rewrite
https://mrc-ide.github.io/safir/
Other
1 stars 2 forks source link

Bug/nimue deaths #10

Closed slwu89 closed 3 years ago

slwu89 commented 3 years ago

write new function get_parameters_nimue to ensure exact match between parameters used in nimue::run and safir when arguments passed are identical. confirm convergence improves with decreasing step size (down to dt=0.05).

codecov[bot] commented 3 years ago

Codecov Report

Merging #10 (71d4267) into main (43aae34) will decrease coverage by 0.65%. The diff coverage is 3.33%.

:exclamation: Current head 71d4267 differs from pull request most recent head 4348a46. Consider uploading reports for the commit 4348a46 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   28.89%   28.23%   -0.66%     
==========================================
  Files          21       21              
  Lines        1163     1190      +27     
==========================================
  Hits          336      336              
- Misses        827      854      +27
Impacted Files Coverage Δ
R/events.R 0.00% <ø> (ø)
R/events_exposure.R 0.00% <ø> (ø)
R/events_exposure_nimue.R 0.00% <ø> (ø)
R/events_hospital.R 0.00% <ø> (ø)
R/events_vaccination_nimue.R 0.00% <0.00%> (ø)
R/initialize_events.R 0.00% <ø> (ø)
R/initialize_events_nimue.R 0.00% <ø> (ø)
R/parameters.R 97.95% <ø> (ø)
R/parameters_nimue.R 0.00% <0.00%> (ø)
R/process_infection.R 0.00% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 43aae34...4348a46. Read the comment docs.