search

mrc-ide / safir

squire and friends individual rewrite
https://mrc-ide.github.io/safir/
Other
1 stars 2 forks source link

fix external FoI for all infection processes #38

Closed slwu89 closed 2 years ago

slwu89 commented 2 years ago

36 did not fully address the issue, this PR adjusts all infection processes to check for > 0 susceptibles, > 0 infectives, and > 0 external FoI term. It addresses each appropriately and clears up the code.

codecov[bot] commented 2 years ago

Codecov Report

Merging #38 (35cd092) into main (aab96c3) will increase coverage by 0.33%. The diff coverage is 100.00%.

:exclamation: Current head 35cd092 differs from pull request most recent head 5f2b113. Consider uploading reports for the commit 5f2b113 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   63.62%   63.95%   +0.33%     
==========================================
  Files          37       37              
  Lines        2059     2078      +19     
==========================================
+ Hits         1310     1329      +19     
  Misses        749      749
Impacted Files Coverage Δ
R/process_infection.R 100.00% <100.00%> (ø)
R/process_infection_nimue.R 100.00% <100.00%> (ø)
R/process_infection_vaccine.R 100.00% <100.00%> (ø)
src/process_infection.cpp 100.00% <100.00%> (ø)
src/process_infection_nimue.cpp 100.00% <100.00%> (ø)
src/process_infection_vaccine.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aab96c3...5f2b113. Read the comment docs.