search

mrc-ide / safir

squire and friends individual rewrite
https://mrc-ide.github.io/safir/
Other
1 stars 2 forks source link

correct errors in vignette and clean up code #48

Closed slwu89 closed 2 years ago

slwu89 commented 2 years ago

natural_immunity.Rmd vignette was using the wrong NAT update function, change to natural_immunity_ab_titre_process from vaccine_ab_titre_process. Also clean up code and add tests to updating NAT values.

codecov[bot] commented 2 years ago

Codecov Report

Merging #48 (38b6b30) into main (e1dbc0a) will increase coverage by 4.47%. The diff coverage is 8.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   64.44%   68.92%   +4.47%     
==========================================
  Files          37       35       -2     
  Lines        2160     2040     -120     
==========================================
+ Hits         1392     1406      +14     
+ Misses        768      634     -134
Impacted Files Coverage Δ
R/efficacy_naturalimmunity.R 96.29% <ø> (+51.85%) :arrow_up:
R/efficacy_vaccination.R 93.75% <ø> (ø)
R/initialize_events.R 0.00% <0.00%> (ø)
R/utils.R 84.31% <100.00%> (+0.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1dbc0a...38b6b30. Read the comment docs.