mrc-ide / safir

squire and friends individual rewrite
https://mrc-ide.github.io/safir/
Other
1 stars 2 forks source link

user selected time step #8

Closed slwu89 closed 3 years ago

slwu89 commented 3 years ago

Restructure model to accept user input dt (step size). All processes and event schedulers which need to compute transition probabilities have been rewritten to compute based on dt.

This PR should also address "3. State initialisation" in the google doc; the function setup_events in R/initialize.R (sorry about the z) schedules events for individuals starting in all states before the model run begins, so that it could be initialized with people in any states, not just S and E.

Currently I have not written a nice wrapper like run_simulation because I expect things will be changing a lot as we add vaccination.

Old files that are unneeded were put in R/deprecated.

Redoing the validation against squire with dt=0.1 the two models seem to be giving very similar results. Rplot2

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@1a2996e). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 02f73ff differs from pull request most recent head a4b5321. Consider uploading reports for the commit a4b5321 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   42.07%           
=======================================
  Files           ?       12           
  Lines           ?      782           
  Branches        ?        0           
=======================================
  Hits            ?      329           
  Misses          ?      453           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a2996e...a4b5321. Read the comment docs.