Portfolio: details popup window Added

[mrcbq]

In this opportunity, the repo had:

🏁 When the user clicks (or taps) the button to check project details, the popup with details about the project appears. 🏁 When the user clicks (or taps) the close (X) button, the popup disappears. 🏁 Using a JavaScript array to store all of the information for all projects. at a minimum: name, description, featured image, technologies, link to live version, link to the source. 🏁 Main page Updated. Now projects section is created dynamically using the information stored in that JavaScript object. all of the HTML in that section is created when the page loads. 🏁 Popup window for mobile and desktop versions implemented.

[mrcbq]

Project Status: CHANGES REQUIRED

Hi @mrcbq and @Gardimy ,

Great work on making the changes requested by a previous reviewer clap You've done well implementing some of the requested changes, but there are still some which haven't been addressed yet.

Highlights

• Popup works as expected heavy_check_mark
• No linter errors heavy_check_mark
• Professional Readme heavy_check_mark

Required Changes

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!clapclapclap

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @NahnahAJ in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sorry, I already updated the repository with the requested changes.

🤦🏼 I didn't realize that I hadn't pushed the changes to the repository I was working on. I had basically left the repository intact because I was working on another repository, I pushed there and quickly left home.

Thanks for the second revision, I have worked very hard on the requested refactoring, I hope it is approved.

[mrcbq]

Sorry, I already updated the repository with the requested changes.

🤦🏼 I didn't realize I hadn't pushed the changes to the repository I was working on yesterday. I had basically left the repository intact because I was working on another repository, I pushed there and quickly left home.

Thanks for the second revision, I have worked very hard on the requested refactoring, I hope it is approved.

[ahmetbozaci]

Hello @mrcbq

This is an additional review as a result of the second opinion request.

• If you haven't pushed the changes, the second code reviewer is correct in asking you to do so. Only fill out the second opinion form, mentioned here, if you believe the code reviewer's feedback is unfair. The second opinion is not for an additional review. Please kindly request a review again from your dashboard.

---

Cheers and Happy coding! 💻 👏

---

GitHub | LinkedIn | Twitter

Reviewed by Ahmet Bozacı

[mrcbq]

Today has not been my day. You can see that in the first review, I was asked for some changes, I did those yesterday all day, but when I submitted the second code review request I didn't update the changes properly in my repository but instead updated the changes in my code partner's repository. I left the house in a hurry up way.

After it arrived, I continued working on the form validation in its validation-form branch and the local storage exercise in its respective localStorage branch.

At some point when I merged the changes from the other branches (validate-contact-form and popup ) what I had in the popup branch was merged and the pull request was closed.

however, the code of my main branch is updated with the requested changes.

I met with a few people who advised me that what I should do is try to explain the situation and submit the latest code review request.

I already corrected everything that the previous code reviewer asked me to do.

[Gardimy]

Hello Dear Marco,

How are you? Please don't worry about that. I know you made a great effort to complete the projects. It is the same for me. But we have time, we can always continue to fix the issues together.

Take care of yourself.

On Fri, Apr 14, 2023 at 11:13 PM Marco Baquero @.***> wrote:

Today has not been my day. You can see that in the first review, I was asked for some changes, I did those yesterday all day, but when I submitted the second code review request I didn't update the changes properly in my repository but instead updated the changes in my code partner's repository. I left the house in a hurry up way.

After it arrived, I continued working on the form validation in its validation-form branch and the local storage exercise in its respective localStorage branch.

At some point when I merged the changes from the other branches (validate-contact-form and popup ) what I had in the popup branch was merged and the pull request was closed.

however, the code of my main branch is updated with the requested changes.

I met with a few people who advised me that what I should do is try to explain the situation and submit the latest code review request.

I only have one Code review request left, please be patient with this review.

— Reply to this email directly, view it on GitHub https://github.com/mrcbq/portfolio-mobile-first/pull/9#issuecomment-1509483088, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2SPKRMOABLANEUCGKYQMUTXBIG45ANCNFSM6AAAAAAW5JLREU . You are receiving this because you were mentioned.Message ID: @.***>