search

mrchrisster / MiSTer_SAM

154 stars 22 forks source link

Feature Request: Add 'ignore' key to script #220

Closed stopmosk closed 1 year ago

stopmosk commented 1 year ago

Hi

It would be great to add the ignore argument to the SAM script so that the currently playing core is not just skipped (skip | next), but added to the ignore list and is no longer available.

mrchrisster commented 1 year ago

Great idea! Exclude lists are a bit cumbersome to edit by hand and this should be fairly easy to get implemented.

mrchrisster commented 1 year ago

Added in the most recent release. You can ignore a game now by issuing: /media/fat/Scripts/MiSTer_SAM_on.sh ignore or through SAM's menu

Steps to check if it is working correctly (example for arcade core):

  1. Start with a fresh boot and update SAM
  2. Start SAM by waiting or launching it with /media/fat/Scripts/MiSTer_SAM_on.sh start
  3. Issue /media/fat/Scripts/MiSTer_SAM_on.sh ignore
  4. Check that /media/fat/Scripts/.MiSTer_SAM/SAM_Gamelists/arcade_excludelist.txt was created with right game.
  5. Reboot MiSTer and start SAM again.
  6. Now check with cat /tmp/.SAM_List/arcade_gamelist.txt | grep -i "excluded game" if game is missing (it might take a couple of seconds for game to get excluded)

Please let me know if everything is working for you.

stopmosk commented 1 year ago

Hi! Thank you for the new feature!

I went through the steps: 1-5 finished as you described, but I cant understand step 6. What do I get with it? Nothing was changed after it in my case.

mrchrisster commented 1 year ago

If the command completes without showing anything it means that the game is missing. If you have trouble with grep you can also just open that file with filezilla ( /tmp/.SAM_List/arcade_gamelist.txt ) to see if your game is not on that list

mrchrisster commented 1 year ago

Feature seems to be working well for me so I'm closing the issue for now. Please re-open if you encounter any issues