mrchypark / elbird

R binding package Kiwi(Korean Intelligent Word Identifier)
https://mrchypark.github.io/elbird/index.html
Other
34 stars 3 forks source link

need to fix compile setting #43

Closed mrchypark closed 2 years ago

mrchypark commented 2 years ago

https://cran.r-project.org/web/checks/check_results_elbird.html

mrchypark commented 2 years ago
1)  Your SystemRequirements is completely wrong:

SystemRequirements:     c("C++11", "git", "wget", "cmake")

- that is not the right format, and the code use to detect C++11 does
not know that format.

- It completely misses libkiwi. And as there are several projects of
that name, it needs to explain where to get it.

- wget is not portable and not even available on macOS.  You do not test
for it in your configure script, although 'Writing R Extensions'
requires you to do so.

- cmake is not portable, and again you do not test it is actually found
before using it.

2) You are not compiling libkiwi with even the same compiler as used to
compile R, let alone the same flags.  This is discussed extensively in
'Writing R Extensions'.

3) The build of libkiwi is very noisy.  This should be logged in a
config.log file, and only highlights reported.  Things like

<quote>
Note: switching to 'd72769299d49013457638590365ea1dc927bd2de'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

   git switch -c <new-branch-name>

Or undo this operation with:

   git switch -

Turn off this advice by setting config variable advice.detachedHead to false
</quote>

are a waste of the would-be installer's time.
mrchypark commented 2 years ago

https://github.com/Rblp/Rblpapi

third party so library use case.

mrchypark commented 2 years ago

https://github.com/mrchypark/elbird/pull/45

mrchypark commented 2 years ago

오잉 이거 왜 살렸지.