search

mrchypark / multilinguer

Gentle Programming Language Installer (like JDK, conda) for R User
https://mrchypark.github.io/multilinguer/
Other
7 stars 2 forks source link

func name should be install_* instead of has_* #11

Closed kkweon closed 4 years ago

kkweon commented 5 years ago

https://github.com/mrchypark/multilinguer/blob/3478a8f13b60ea2f1fd459676be81d145b678645/R/has.R

mrchypark commented 5 years ago

Thank you for your good suggestion.

I will consider it.

I understand what your saying. I know about this issue. I want to has_* func name looks like declarative status.

Anyway, multilinguer package import correttor and conda4r packages for java & python. There packages have func install_corretto and install_conda.

kkweon commented 5 years ago

Sorry, I don't understand.

has_* name implies it's a pure function that simply returns boolean, but it has a pretty big side effect, which is not expected based on the function name.

But, that's just my 2 cents. closing.

mrchypark commented 5 years ago

Oh, I understand.

Do you have any suggestion? I don't want to use install_* name.

kkweon commented 5 years ago

image

mrchypark commented 4 years ago

I change has* to install*.

thank you for issue!

mrchypark commented 2 years ago

그러게요. 이제와서 보니 has라고 하면 check 동작이어야 이해하기 쉽군요.