Fix LSP Snippets Issue - Githubissues

mrcjkb / haskell-tools.nvim

🦥 Supercharge your Haskell experience in neovim!

GNU General Public License v2.0

432 stars 18 forks source link

Fix LSP Snippets Issue #370

Closed johnhampton closed 2 months ago

johnhampton commented 2 months ago

This PR fixes an issue where LSP snippets were not working. The default capabilities from vim.lsp.protocol.make_client_capabilities()were taking precedence over those from cmp_nvim_lsp.default_capabilities(). The merge order has been updated to ensure cmp_nvim_lsp.default_capabilities() takes precedence.

github-actions[bot] commented 2 months ago

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

For example, fix(lsp): some lsp-related bugfix
[ ] Pull request title has the appropriate conventional commit prefix.

If applicable:

[ ] Tested
- [ ] Tests have been added.
- [ ] Tested manually (Steps to reproduce in PR description).
[ ] Updated documentation.
[ ] Updated CHANGELOG.md

mrcjkb commented 2 months ago

Hey :wave:

thanks for the PR. I've addressed the issue in a slightly different way: https://github.com/mrcjkb/haskell-tools.nvim/commit/65d6993eba1a56bbd5211ef13a100d26ce3e644a

mrcjkb commented 2 months ago

@all-contributors please add @johnhampton for code

allcontributors[bot] commented 2 months ago

@mrcjkb

I've put up a pull request to add @johnhampton! :tada: