search

mrclay / minify

Combines. minifies, and serves CSS or Javascript files
BSD 3-Clause "New" or "Revised" License
3k stars 472 forks source link

Unit test "framework" is weak #265

Closed mrclay closed 8 years ago

mrclay commented 9 years ago

Originally reported on Google Code with ID 121

There, I said it. :) It's much better than no tests, but we really should 
be using SimpleTest.

Feeling out the server environment (e.g. ability to write files, detect 
auto-compression) needs to be easier to run on first "install". Maybe /min/
setup/ could run a little suite.

For now it seems reasonable to require devs running units to have 
SimpleTest be in the include_path, but maybe there's a way to link this in 
with svn without adding it all to our repo.

Reported by mrclay.org on 2009-06-29 02:03:28

mrclay commented 9 years ago 
If no cache path is set, the setup should sniff with Solar_Dir, test read/write, and

suggest using that directory.

Reported by mrclay.org on 2009-09-09 01:09:24

glensc commented 9 years ago

@mrclay what was your opinion to add phpunit based testing?

i would like to add new processor using nailgun to launch closure compiler. i would like to add unit test there, but i find phpunit test setup more stright forward than the webbased tests you have now.

the current tests can stay, as still need to test with browser.

but the new test i plan to add, would be just testing the new class.

so, if you say +1, would be appropriate to add second unit test tree?:

or mix with current /min_unit_tests/ ?

glensc commented 8 years ago

unit tests were ported to phpunit in #486