search

mrcljx / rubocop-for-rubymine

DEPRECATED: RubyMine supports RuboCop now
https://blog.jetbrains.com/ruby/2017/01/rubymine-2017-1-eap-2-creating-gemsets-rubocop-support/
MIT License
131 stars 29 forks source link

Can JRuby be supported? #5

Closed olleolleolle closed 8 years ago

olleolleolle commented 9 years ago

<3 this project, a very nice, worked-through add-on.

Looking at this line, it seems that RUBY_SDK is not the same as a JRuby.

https://github.com/sirlantis/rubocop-for-rubymine/blob/5e3670677e0ab8462bb29e404ad120d661e3155c/src/io/github/sirlantis/rubymine/rubocop/RubocopTask.kt#L225

mrcljx commented 9 years ago

Can you somehow find out what String is reported for JRuby? I can't find any information from IntelliJ.

olleolleolle commented 9 years ago

Dumb answer, probably unrelated: In JRuby, all I know is that, RUBY_PLATFORM == 'java'.

olleolleolle commented 8 years ago

Hooray!

mrcljx commented 8 years ago

Would be happy if you could verify this (3.0.0 required) - worked on my system but you know how it is... ;)

olleolleolle commented 8 years ago

You have yet to tag the 3.0.0 release, is that right?

olleolleolle commented 8 years ago

Oh, I found it!