fix Adafruit_GFX override setRotation

mrcodetastic / ESP32-HUB75-MatrixPanel-DMA

An Adafruit GFX Compatible Library for the ESP32, ESP32-S2, ESP32-S3 to drive HUB75 LED matrix panels using DMA for high refresh rates. Supports panel chaining.

MIT License

939 stars 208 forks source link

fix Adafruit_GFX override setRotation #543

Closed Lukaswnd closed 9 months ago

Lukaswnd commented 9 months ago

The Adafruit_GFX uses setRotation(uint8_t), while the virtual matrix display uses setRotation(int). Therefore there is no implicit override and if you call the function either with an uint8_t or from an Adafruit_GFX* the overloaded funtion is not called.

mrcodetastic commented 9 months ago

This has to be the most inadvertent and obscure bug I've created. Thanks for fixing.

Lukaswnd commented 9 months ago

Well I hope all of your bugs are inadvertent, obscure or fixed ;) I'm glad I could help

mrcodetastic commented 9 months ago

Appreciate it greatly! Merry Christmas!