mrcomac / token-action-hud-swade

FoundryVTT Token Action HUD for Savage Worlds
MIT License
5 stars 4 forks source link

[Bug] Powers shows non existing Power Points for a character #16

Closed Vogliadicone closed 1 year ago

Vogliadicone commented 1 year ago

After updating to v0.7.2 all Magix users see "Power Points" for their own and a lot of other pp categories.

Example 1: A sorcerer with 25pp from Sorcery: HUD_2 The HUD shows pp also for General, Magic, Magic Items, Max & Cleric (Luck) (the character has no magic items with pp): HUD_1

Example 2: A cleric with 20pp from Cleric (Luck): HUD_3 The HUD shows pp also for General, Magic, Sorcery, Magic Items & Max (the character has no magic items with pp): HUD_4

Maybe the categories are all somewhere in the game world available pp categories? At least in the scene I took the screenshot from, there are no token that have pp from General, Magic, Magic Items or Max. But maybe somewhere in an compendium (f.e. in Savage Pathfinder) is an item or creature with one of these? Anyway, it's quite irritating, to have 6 categories where the player should only see one.

Let me know, if I can help you with more data.

mrcomac commented 1 year ago

Hi @Vogliadicone I'll need to investigate that. Could you please export this character to allow me troubleshoot using that character?

Vogliadicone commented 1 year ago

Sure, here you have the two characters from the example above (I had to zip them, since github didn't support the upload of json files): 2-magic-users.zip

mrcomac commented 1 year ago

Thank you, I'll have a look into it next weekend or before it (depends on my workload this week)

Vogliadicone commented 1 year ago

Pleae, no stress. I’m just looking into this stuff right now, because I just updated to v11 and my group is in its summer break and therefore I have time for this 😜 Just happy that somebody wrote a module for the new Token HUD.

Vogliadicone commented 1 year ago

Thanks! I needed to reset the Token Action HUD via the "Reset HUD" option after updating to 0.7.3 to get rid of the other power categories, but now it works. Until now I really had to reset the HUD after every update. Don't know, if it's just a issue with the SWADE HUD or if this is a general problem, but maybe pushing a notification after an update might be an idea...

mrcomac commented 1 year ago

Token HUD saves the layout to a file. I need to figure out how to validate if it's an update and reset it programmatically, the problem of thos, it will remove custom config.

mrcomac commented 1 year ago

Probably the core hud has an option to make this with low impact. I need to xheck it.