mrcomac / token-action-hud-swade

FoundryVTT Token Action HUD for Savage Worlds
MIT License
5 stars 4 forks source link

Trying to make attacks from the HUD, some weapons not working properly, others not working at all. #20

Closed sroakjp closed 9 months ago

sroakjp commented 1 year ago

Describe the bug I have a token with 3 melee weapons. One was already there when the issue first appeared, the others I added trying to troubleshoot this issue. If I select the first weapon from the HUD the Better Rolls 2 (BR2) card appears as expected. I'm trying to make a wild attack, so I select that action and press roll. The attack works, but the vulnerable status is not applied. Repeating this, selecting the weapon from the character sheet, and it works as expected. The other two weapons do nothing when selected from the HUD and an error appears in the console.

Steps to reproduce

  1. Select weapon from HUD
  2. If weapon card appears in chat, (no error message)
  3. Select Wild Attack
  4. Press roll button
  5. Notice, no Vulnerable status

Newly added weapon:

  1. Select weapon from HUD
  2. Nothing happens, error message, see below, appears in browser console.

Versions:

Additional context Error message, for weapons that do nothing image

Console output for attack that should have applied Vulnerable status but did not (2 images) image image

mrcomac commented 1 year ago

that is a bug. BR2 is waiting for (token|actor, itemID, collapse_actions)

I need to fix how HUD is calling it within _rollItem()

next release will have a fix.

mrcomac commented 1 year ago

Hi @sroakjp

Version 0.7.6 should address this issue. If issue persists feel free to comment here please.

mrcomac commented 1 year ago

It probably isn't resolved yet. Issue #22

mrcomac commented 9 months ago

i'm not able to reproduce this issue, i'm assuming after some updates in br2 and the token action hud swade this issue doesn't exist anymore. please, let me know if it persists in your end.