search

mrcomac / token-action-hud-swade

FoundryVTT Token Action HUD for Savage Worlds
MIT License
5 stars 4 forks source link

Weapons with BR2 #22

Closed Alekboldlin closed 8 months ago

Alekboldlin commented 1 year ago

Describe the bug When trying to use weapon from hud with better rolls 2 installed, in chat card shows up, but there is no roll. Better rolls setting are set as Show card and trait roll. There is a error in console. Attributes and Skills works fine.

image image

Steps to reproduce

  1. Add weapon to actor
  2. Activate it from hud

Versions:

mrcomac commented 1 year ago

I'll have a look late this week. Probably I need to call br2 using another function.

mrcomac commented 9 months ago

after some updates i can't reproduce this issue, please let me know if this issue persists in your end.

Alekboldlin commented 9 months ago

I updated to version 0.8.5 and module isn't loading at all. :(

image

mrcomac commented 9 months ago

please update to v0.8.6

Alekboldlin commented 9 months ago

Ok, so weapons are working now. But every time I roll for skills or attributes benny is also spend, dunno why. And there is also this wrong name in settings tab. image

mrcomac commented 9 months ago

That's odd. It should be the config for the hud. Maybe because I have the dev module in my environment it's working.

Do you mind share the json of a char? This way I can import to my environment and test using your char specifically.

mrcomac commented 9 months ago

I'll test without de dev module and using a char as example I can try fix both issues

Alekboldlin commented 9 months ago

I don't know what You mean by char. Character? World? Or something else?

mrcomac commented 9 months ago

yes, the sheet of the actor.

steveculshaw commented 9 months ago

NOTE: the screenshots of BR2 are for an older version ... and there have been a lot of changes in BR2, so this may debugging the issue a bit of a challenge :-(

Alekboldlin commented 9 months ago

Last patch fixed unmapped tab issue, but there is still spending benny on attributes and skills. Here You go, exported actor. fvtt-Actor-orc-q3FngZpeN8M6jieU.json

mrcomac commented 9 months ago

thanks for the json please test v0.9.1 it should solve the bennie issue and adds support to AE

Alekboldlin commented 9 months ago

Tested it, and everything looks ok.

Btw any chances that we will get feature so when You click button with Shift, Alt or Ctrl it will activate corresponding action? And support for new action in BR2 called "Show the card and open the action dialog"?

mrcomac commented 9 months ago

the button behaviour should already there

image

the new option "Show the card and open the action dialog" i didn't see yet. do you have an example to share?

mrcomac commented 9 months ago

oh, i see what you meant.

Alekboldlin commented 9 months ago

About button behaviour I meant extra settings in tab so You can configure extra actions.

Now after You set for example Single click action in Token Action HUD SWADE it will always do this action. Doesn't matter if I do LBM click on HUD , Shift+LBM etc. it always do only single click action.

But how about setting so if I press LBM on HUD it will do single click action, if I press Shift+LBM on HUD it will do Shift click action.

I am pretty sure it was working like this in some point in the past.

mrcomac commented 9 months ago

the config works in this way if you select in the configuration of the HUD "single click action" it will retrieve the behaviour from the "single click action" configured in BR2

If BR2 has selected the option "default system roll" in the "single click action", HUD will adopt this behaviour.

In other words, the hud retrieves the behaviour configured for that option from BR2.

However, the dialog behaviour is something new, it will be available in the next version of this module.

in the future, if you configure BR2 to display the dialog box pressing CTRL, if you go to the config HUD and select to behaviour like CTRL click action, it will display the dialog box.

mrcomac commented 9 months ago

to change the behaviour based on the click, like you mentioned, i will need to check how to do it.

mrcomac commented 8 months ago

@Alekboldlin are you able to test v0.9.3? it provides the click behaviour. You can select the default behaviour from the settings (for example, if you want the HUD behaviour to copy some behaviour from BR2, or just pressing CRTL, SHIT or ALT)

Alekboldlin commented 8 months ago

Sorry, didn't want to close issue (fat fingers). So from my testing all behaviour is as expected. All function keys are working. So good job, and thank You.

So about new option of "Show the card and open the action dialog". This is how it looks like when You press weapon or skill on character sheet. image