search

mrcrowl / vscode-easy-less

Easy LESS extension for Visual Studio Code
MIT License
67 stars 23 forks source link

HEX color autoreplacment should not be the default behavior #3

Closed thecosss closed 7 years ago

thecosss commented 8 years ago

I'm trying to switch to VSCode now in my project. I've test-compiled my styles and saw this stuff in my diff

-  color: #ffffff;
+  color: #fff;
-  background: linear-gradient(to bottom, #f17a4c, #ef6262);
+  background: linear-gradient(to bottom, #F17A4C, #EF6262);

I think that should not be the default behavior, Easy Less should compile hex colors as is by default. Everything else is seem to be working fine.

mrcrowl commented 8 years ago

That's very interesting. I can't easily reproduce the issue on my side. I've just tried now with a one-file example, and it appears to preserve them hex colors as typed.

Can you send me an isolated example where you are seeing this issue occur?

On Sat, 20 Feb 2016 at 19:53 thecosss notifications@github.com wrote:

I'm trying to switch to VSCode now in my project. I've test-compiled my styles and saw this stuff in my diff

  • color: #ffffff;
  • color: #fff;
  • background: linear-gradient(to bottom, #f17a4c, #ef6262);
  • background: linear-gradient(to bottom, #F17A4C, #EF6262);

I think that should not be the default behavior, Easy Less should compile hex colors as is by default. Everything else is seem to be working fine.

— Reply to this email directly or view it on GitHub https://github.com/mrcrowl/vscode-easy-less/issues/3.

mrcrowl commented 8 years ago

Also, are you seeing diff changes to the css or the less files?

On Sat, 20 Feb 2016 at 21:05 Ben Crowl mrcrowl@gmail.com wrote:

That's very interesting. I can't easily reproduce the issue on my side. I've just tried now with a one-file example, and it appears to preserve them hex colors as typed.

Can you send me an isolated example where you are seeing this issue occur?

On Sat, 20 Feb 2016 at 19:53 thecosss notifications@github.com wrote:

I'm trying to switch to VSCode now in my project. I've test-compiled my styles and saw this stuff in my diff

  • color: #ffffff;
  • color: #fff;
  • background: linear-gradient(to bottom, #f17a4c, #ef6262);
  • background: linear-gradient(to bottom, #F17A4C, #EF6262);

I think that should not be the default behavior, Easy Less should compile hex colors as is by default. Everything else is seem to be working fine.

— Reply to this email directly or view it on GitHub https://github.com/mrcrowl/vscode-easy-less/issues/3.

thecosss commented 8 years ago

I'm seeing diff changes in CSS files.

mrcrowl commented 7 years ago

@thecosss, feel free to open this issue with an example that I can look into.