mrdbourke / pytorch-deep-learning

Materials for the Learn PyTorch for Deep Learning: Zero to Mastery course.
https://learnpytorch.io
MIT License
10.49k stars 3.09k forks source link

Put section number for Section 5 "Equation 2: Multihead Self-Attention (MSA block)" #817

Closed ideaguy3d closed 1 month ago

ideaguy3d commented 8 months ago

When viewed from an IDE with navigation (e.g. DataSpell) it looked like

4. Equation 1: ...
Equation 2: ...
6. Equation 3: ...

so I simply added "5." to make it clearer "5. Equation 2: Multihead Self-Attention (MSA block)" is the 5th section

smith-kyle commented 8 months ago

I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/mrdbourke/pytorch-deep-learning/pull/817

It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews.

mrdbourke commented 1 month ago

Thank you @ideaguy3d !