search

mrdoob / htmleditor

Simple editor for messing around.
https://mrdoob.com/projects/htmleditor/
MIT License
592 stars 174 forks source link

Fixed toolbar buttons z-index #13

Closed jcguarinpenaranda closed 8 years ago

jcguarinpenaranda commented 9 years ago

The toolbar buttons were not clickable because they were appearing behind the layer of the code. Now they are clickable.

mrdoob commented 8 years ago

What browser is this with? There should be nothing on top of the toolbar (apart from the popup). https://github.com/mrdoob/htmleditor/blob/master/index.html#L170-L173

jcguarinpenaranda commented 8 years ago

It was on Firefox Developer Edition, the latest version El sept. 24, 2015 6:42 PM, "Mr.doob" notifications@github.com escribió:

What browser is this with? There should be nothing on top of the toolbar (apart from the popup). https://github.com/mrdoob/htmleditor/blob/master/index.html#L170-L173

— Reply to this email directly or view it on GitHub https://github.com/mrdoob/htmleditor/pull/13#issuecomment-143080937.

mrdoob commented 8 years ago

Hmm... Indeed, it's an issue in Firefox.

Seems like CodeMirror is adding z-index: 2 to .CodeMirror pre and Firefox gives priority to z-index rather than dom elements order.

I wonder if this follows the spec or if it's a bug in Firefox...?

jcguarinpenaranda commented 8 years ago

El 27/09/2015, a las 9:50 a.m., Mr.doob notifications@github.com escribió:

Hmm... Indeed, it's an issue in Firefox.

Seems like CodeMirror is adding z-index: 2 to .CodeMirror pre and Firefox gives priority to z-index rather than dom elements order.

I wonder if this follows the spec or if it's a bug in Firefox...?

— Reply to this email directly or view it on GitHub https://github.com/mrdoob/htmleditor/pull/13#issuecomment-143563864.

Well, maybe it is a bug in Firefox, but, it is better to have support for all browsers right?

mrdoob commented 8 years ago

Well, maybe it is a bug in Firefox, but, it is better to have support for all browsers right?

I want to know if it's a bug in Firefox before adding workarounds.

jcguarinpenaranda commented 8 years ago

El 27/09/2015, a las 10:01 a.m., Mr.doob notifications@github.com escribió:

Well, maybe it is a bug in Firefox, but, it is better to have support for all browsers right?

I want to know if it's a bug in Firefox before adding workarounds.

— Reply to this email directly or view it on GitHub https://github.com/mrdoob/htmleditor/pull/13#issuecomment-143564994.

Hmm, How may I help you?

mrdoob commented 8 years ago

This should be fixed now.