mrdoob / three.js

JavaScript 3D Library.
https://threejs.org/
MIT License
102.51k stars 35.37k forks source link

pointer lock demo does not have to request full screen in firefox #10217

Closed makc closed 7 years ago

makc commented 7 years ago

here it tests for "firefox" and forces full screen. however, as you can see here, it works in normal mode as well (corresponding code is here).

mrdumb commented 7 years ago

http://necromanthus.com/Test/html5/testA_disco.html Press "F" for full screen.

makc commented 7 years ago

that rifle fires blanks.

mrdumb commented 7 years ago

that rifle fires blanks.

Do you like to kill girls and dogs?

Mugen87 commented 7 years ago

here it tests for "firefox" and forces full screen. however, as you can see here, it works in normal mode as well (corresponding code is here).

You're right. It's not necessary any more to be in fullscreen mode in order to request a pointer lock. The API changed over time in Firefox.

makc commented 7 years ago

Do you like to kill girls and dogs?

what if they are Irma Grese kind of girs and dogs

mrdoob commented 7 years ago

Fixed. Thanks!