mrdoob / three.js

JavaScript 3D Library.
https://threejs.org/
MIT License
102.21k stars 35.35k forks source link

Add `changeEnd` for controls #23874

Open susiwen8 opened 2 years ago

susiwen8 commented 2 years ago

Is your feature request related to a problem? Please describe. In R3F, the <AdaptiveDpr /> has a problem, at the end of rotation, it will flick at the end of rotation, I have found out R3F use debounce to detect the end of change event, but the debounce is 200ms, it not enough also it's not reliable, cause different dampingFactor have differnet debounce time.
Kapture_2022-04-09_at_23 37 36

So I wonder, a changeEnd event would be the best solution for this, also this event would bring benifit for something needs to be done after controls if fully stop.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like

A changeEnd event

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

Mugen87 commented 1 year ago

I have found out R3F use debounce to detect the end of change event, but the debounce is 200ms, it not enough also it's not reliable, cause different dampingFactor have differnet debounce time.

Related #20636.