search

mrdougal / textmate2-rubocop

Rubocop bundle for TextMate2
14 stars 9 forks source link

Don't bundle rubocop; s/Rubocop/RuboCop/ #7

Open saizai opened 10 years ago

saizai commented 10 years ago
  1. Bundled version is out of date. Don't include it in the textmate bundle; use the gem version.
  2. The current version uses RuboCop:: not Rubocop::.
mrdougal commented 10 years ago

Granted the bundled version of RuboCop is out of date. I'm confused with your statement. "Don't include it in the textmate bundle; use the gem version" are you saying i shouldn't bundle at all? Or is the bundle not using a version of RuboCop that you have installed outside of the plugin?

"The current version uses RuboCop:: not Rubocop::." - sorry i don't understand what you mean in this statement. Can you elaborate?

Thanks

saizai commented 10 years ago

Yes, the bundle shouldn't include the gem, just a ’require’.

For #2 I meant that literally. The case changed.

brianviveiros commented 8 years ago

Any plans to fix this?

mrdougal commented 8 years ago

Hello To be honest, not right now. In part because i'm not writing much ruby at the moment, and i couldn't get the code in the pull request to work. This is shitty and lazy of me, which leads me to the question would someone like to take over this project? So that it can receive more attention that what i'm giving it.

brianviveiros commented 8 years ago

I'm happy to take it over, let me just look into what's involved before committing to it. I've never build a tmbundle before.