Closed GoogleCodeExporter closed 9 years ago
Btw, the patch will not remove the GrantedAccess column like it appears
above...that was just a copy & paste error when I entered the issue.
Original comment by michael.hale@gmail.com
on 23 Jan 2012 at 5:49
Looks good, the only change I'd ask for is that
def get_item(self, entry, handle_value):
change to
def get_item(self, entry, handle_value = 0):
Otherwise looks good for a commit.
Original comment by mike.auty@gmail.com
on 23 Jan 2012 at 2:24
Oh, one other small note, I don't think the \ is required after the /. The \
character forces the parser to read in the next line, but if an arithmetic
operator is present, it should go to the next line anyway (similarly for
multi-line dictionaries, etc)...
Original comment by mike.auty@gmail.com
on 23 Jan 2012 at 2:28
Uhh oops, I attached the patch for Issue #135 here. The patch for Issue #188
should be named volatility-file-device.patch.
Original comment by michael.hale@gmail.com
on 23 Jan 2012 at 3:16
Attachments:
Hey Ikelos can you take a second look at this now that I've attached the right
patch ;-)
Original comment by michael.hale@gmail.com
on 24 Jan 2012 at 7:01
Looks fine save for the rogue "import volatility.obj as obj". Don't think
that's needed, otherwise all looks good, commit away...
Original comment by mike.auty@gmail.com
on 25 Jan 2012 at 11:49
Thanks! Yeah I think that import volatility.obj was part of some other patch
that snuck in somehow. Thx.
Original comment by michael.hale@gmail.com
on 26 Jan 2012 at 12:12
This issue was closed by revision r1313.
Original comment by michael.hale@gmail.com
on 26 Jan 2012 at 12:59
Original issue reported on code.google.com by
michael.hale@gmail.com
on 23 Jan 2012 at 5:47Attachments: