search

mrdunk / esp8266_mdns

mDNS queries and responses on esp8266
MIT License
77 stars 16 forks source link

Fix for core 3.0.0+, buffer_pointer comparison fixes #19

Closed ajanhalt closed 2 years ago

ajanhalt commented 2 years ago
  1. Move call to startUdpMulticast from constructor to new begin() function
  2. Change some instances of 'buffer_pointer >= data_size' to 'buffer_pointer > data_size'
mrdunk commented 2 years ago

Good PR. Thank you!

ajanhalt commented 2 years ago

First PR for me so I’m glad I didn’t mess it up!

On Wed, Feb 2, 2022 at 5:07 PM dunk @.***> wrote:

Good PR. Thank you!

— Reply to this email directly, view it on GitHub https://github.com/mrdunk/esp8266_mdns/pull/19#issuecomment-1028441758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AL47HYUBSYZVBPZBGT4R26TUZG2MHANCNFSM5NNAGVLQ . You are receiving this because you authored the thread.Message ID: @.***>