search

mre / timelapse

🎬 Native macOS app for recording timelapse videos of your desktop.
https://endler.dev/2020/timelapse/
Apache License 2.0
214 stars 18 forks source link

Add test directory and Recorder class inclusive of 4 unit tests #14

Closed Ticketedmoon closed 6 years ago

Ticketedmoon commented 6 years ago

I just added a test directory to work from as well as 4 unit tests revolving around the Recorder class.

mre commented 6 years ago

Great work. Could you move the tests to tests/test_recorder.py? (We added this structure yesterday.)

Ticketedmoon commented 6 years ago

All done now.

mre commented 6 years ago 
tests/test_recorder.py:5: in <module>
    from recorder import Recorder
E   ModuleNotFoundError: No module named 'recorder'

😅

mre commented 6 years ago

I don't know what to do here. Maybe from timelapse.recorder import Recorder?

Ticketedmoon commented 6 years ago

Should be good now, my bad.

Ticketedmoon commented 6 years ago

Build still seems to be failing, I'll look into it

Ticketedmoon commented 6 years ago

Not sure why the build is failing. It's something to do python not registering the project as a package hierarchy, so you can't import between modules. If you run it manually however, the tests should work.

Shane,

mre commented 6 years ago

I moved the code into its own subfolder named timelapse and that did the trick. This is a best practice according to the docs. Your original commits are part of the rollup in #15. Would you be okay with merging #15 and closing this one? (Note: This still counts as a contribution to Hacktoberfest of course, if that is interesting to you. 😉)

Ticketedmoon commented 6 years ago

It is for Hacktoberfest yup and gladly! I'll merge and close once I get home.