Update dependencies - Githubissues

mre / timelapse

🎬 Native macOS app for recording timelapse videos of your desktop.

https://endler.dev/2020/timelapse/

Apache License 2.0

214 stars 18 forks source link

Update dependencies #26

Closed mre closed 5 years ago

mre commented 5 years ago

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[X] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Update the versions of all packages
Slightly improve check for ffmpeg

Checklist

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[X] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

cmangla commented 5 years ago

Here is my requirements.txt, attached. I just installed the latest versions. Worked fine for me. requirements.txt

mre commented 5 years ago

Thanks @cmangla. Yeah I was struggling with pip for a bit. Should have remembered that you posted the command to get the latest versions in your previous issue; but I didn't. 😆 Anyway, the build still breaks. Let's see why...

mre commented 5 years ago

Yeah, the tests break. Should have covered that in my last review, heh. Let's see if I can fix it.

cmangla commented 5 years ago

Yeah, the tests break. Should have covered that in my last review, heh. Let's see if I can fix it.

Sorry, my fault. isSet needs to be changed to is_set.

mre commented 5 years ago

Perfect. That fixed it. Can't add you as a reviewer, because you were not a collaborator. Sent you an invite link to fix that. 😉

mre commented 5 years ago

Thanks. Yeah I'm using Vim; removed now. 🤦‍♂ Thankfully there is a squash functionality in git...

mre commented 5 years ago

Cool. Thanks for the review.