Added support for multi monitor configurations; the screen captured w…

mre / timelapse

🎬 Native macOS app for recording timelapse videos of your desktop.

https://endler.dev/2020/timelapse/

Apache License 2.0

214 stars 18 forks source link

Added support for multi monitor configurations; the screen captured w… #28

Closed gkpln3 closed 4 years ago

gkpln3 commented 4 years ago

Added support for multi-monitor configurations; the screen captured will always be the one with the mouse in it.

Description

Types of Changes

[ ] Core
[ ] Bugfix
[x] New feature
[ ] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

cmangla commented 4 years ago

If you run the project regression tests in your branch through github actions, the linter should pick up any simple issues like naming conventions.

mre commented 4 years ago

@gkpln3, thanks for the PR. That sounds very promising. @cmangla thanks for the initial review. It looks like your concerns were addressed now. Do you have time to give it a spin on your local machine to see if it works as expected? If not, I could do it but it might take a bit longer.

cmangla commented 4 years ago

Yes @mre , they are indeed resolved now. Thanks @gkpln3 .

@mre I'm currently just working from my laptop so I don't have a second monitor to test this with. Will see if I can borrow one, but not sure.

mre commented 4 years ago

Ah no worries. I had a spare screen and set it up to test the PR. Works like a charm. Merging! Thanks to both of you. 😊 👍