Make app top directory in zip

mre / timelapse

🎬 Native macOS app for recording timelapse videos of your desktop.

https://endler.dev/2020/timelapse/

Apache License 2.0

214 stars 18 forks source link

Make app top directory in zip #36

Closed cmangla closed 4 years ago

cmangla commented 4 years ago

timelapse.zip contains dist/Timelapse.app, which might confuse some end users, so might be better to have Timelapse.app in the .zip without the dist directory.

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[x] Enhancement/optimization
[ ] Documentation

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

cmangla commented 4 years ago

@mre How do I test this?

mre commented 4 years ago

That's a great idea!

@mre How do I test this?

Don't think you can. There used to be a tool for that, but it wasn't updated for the new YAML syntax yet. https://stackoverflow.com/questions/59241249/how-to-run-github-actions-locally I usually test the changes in a branch and then squash the changes once I'm happy, but for releases that's tricky. I'd suggest we merge this as soon as we're happy with it and then see what happens? 😅

cmangla commented 4 years ago

I'd suggest we merge this as soon as we're happy with it and then see what happens? 😅

@mre Cool, I'll try that now then :)

mre commented 4 years ago

It looks like we're good! The pipeline didn't 💥, so maybe you can bump the version number to 0.996 and create a release at https://github.com/mre/timelapse/releases. 🎉 If that's working as planned, the next step is to tag 1.0 and announce it. Kinda crazy to think that this app was almost 10 years in the making... 😆 There should be cake.