Add linter to Github actions - Githubissues

mre / timelapse

🎬 Native macOS app for recording timelapse videos of your desktop.

https://endler.dev/2020/timelapse/

Apache License 2.0

214 stars 18 forks source link

Add linter to Github actions #45

Open mre opened 4 years ago

mre commented 4 years ago

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[X] Enhancement/optimization
[ ] Documentation

Issues Fixed or Closed by This PR

Add linting to the build process. See #33.

Checklist

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

cmangla commented 4 years ago

@mre Wow this is turning out to be a lot of work, but looks great!

mre commented 4 years ago

@cmangla, yeah let's take it as an opportunity to clean up non-idiomatic code. I think the result is great: https://github.com/mre/timelapse/pull/45/commits/6e48d4885702e1799a63b219a05c3ae610a5ee80 If we all fix a few of those lints from time to time, we'll be in a much better position soon.

mre commented 4 years ago

Of course, after pylint, we still have mypy to tackle. And who knows what else. 😆