search

mrehkopf / sd2snes

SD card based multi-purpose cartridge for the SNES
http://sd2snes.de
GNU General Public License v2.0
579 stars 114 forks source link

[v1.11.0b1] Small blemish in "Favorite games" menu #156

Closed Ramsis-SNES closed 1 year ago

Ramsis-SNES commented 2 years ago

If you press B to go back from here (image taken from https://github.com/mrehkopf/sd2snes/pull/134) ...

IMG_20200222_150006

... the menu will flicker slightly, and the selection bar will be placed on the topmost entry in the favorite games list instead on the one the context menu was opened for. (Normally, all sub-menus close without any flickering, and the selection bar is placed on the previously selected element.)

Not a big deal at all, I know, but it just caught my eye. ;-)

Ramsis-SNES commented 1 year ago

Awww, I was hoping for a fix for this in the final version. :p Oh well. ;-)

freelancer42 commented 1 year ago

This one's probably my fault. I implemented the favorites feature after digging through the SD2SNES code without any prior knowledge of how it worked, so I might've picked the wrong subroutine for something. Sorry :) I'm glad people find it useful though!

mrehkopf commented 1 year ago

Heh, forgot about it. I was really too focused on getting the critical stuff to work on Rev.D but I think it was necessary... Will fix it for 1.11.1 ;)

mrehkopf commented 1 year ago

Please give it a try :) menu.zip

Ramsis-SNES commented 1 year ago

Please give it a try :) menu.zip

Works just fine now, thanks a lot, ikari! :D