mrehkopf / sd2snes

SD card based multi-purpose cartridge for the SNES
http://sd2snes.de
GNU General Public License v2.0
579 stars 114 forks source link

[v1.11.0 beta] Final Fantasy 3 US equipment menu screen flickers #159

Open Jeffersonian opened 2 years ago

Jeffersonian commented 2 years ago

FF3 US rom has a graphical issue when you bring up the equipment menu (screen flickers like crazy, menu can’t be viewed). I downgraded to v1.10.3 and the issue doesn’t occur. Tested on a Super Nt. B2A6C3A8-4068-4C7C-A3EF-66C643C4A993

Edit - This appears to be a regression in the in game hook. This exact same issue is reported here:

https://sd2snes.de/blog/compatibility/in-game-hook-compatibility

And is supposed to occur in v0.1.7b, but fixed in later builds.

mrehkopf commented 2 years ago

Unfortunately this is a regression caused by the introduction of the save state handler which is called from the in-game hook. When the in-game hook consumes too much SNES CPU time the HDMA setup of the FF3/6 menu does not finish in time. This is why it was broken in early firmwares before I optimized the in-game hook code. For now it should work fine with in-game save states disabled but I acknowledge that the save state handler is in dire need for CPU time optimization. I will begin optimizing it from v1.11.1. Right now I'm on summer vacation so expect fxpak activities to continue in about two weeks ;)

jfineberg commented 10 months ago

Just wanted to ping here and see if this was still on your radar, @mrehkopf !

mrehkopf commented 10 months ago

Yes, I will attempt a fix after the next release; for the time being the only solution is to turn off in-game savestates, sorry :(