mrehkopf / sd2snes

SD card based multi-purpose cartridge for the SNES
http://sd2snes.de
GNU General Public License v2.0
590 stars 115 forks source link

Super FX screen flicker #262

Open Sunlitspace542 opened 5 days ago

Sunlitspace542 commented 5 days ago

I am using an SD2SNES Mk. II Rev. J, running this firmware: https://github.com/mrehkopf/sd2snes/files/10765998/issue186.zip In some Super FX romhacks, the screen can flash solid black for a frame. Booting the ROM over USB with QUSB2SNES fixes this issue. Apologies for the blurry video, but it should be enough to demonstrate the issue.

https://github.com/user-attachments/assets/44541d40-f0da-4601-bb29-24975aa16371

mrehkopf commented 5 days ago

Can you check if you have the brightness limit or 1chip transient fix enabled in configuration->in-game settings? They don't work reliably with every game due to differences in how each game programs the blanking/brightness register. It probably works using qusb2snes because it doesn't set all features when loading a ROM.

Sunlitspace542 commented 5 days ago

Can you check if you have the brightness limit or 1chip transient fix enabled in configuration->in-game settings?

Just checked, and I don't.

r0g1nh0 commented 4 days ago

With firmware issue186, very thin vertical lines also appear in the Super Mario RPG game and the graphics are of lower quality in others.

Ramsis-SNES commented 4 days ago

In some Super FX romhacks

Which one(s) specifically? Star Fox Exploration, perhaps?

Please bear in mind that in most cases, before finding the cause of an issue you might experience, let alone making any attempt to fix it, a developer has to reproduce it first, i.e. provoke it and see it happen on their own setup. This is obviously only possible and/or becomes a lot easier if you provide as much information with as many details as you can in your report. That said, the name of the game/hack you're having trouble with should be the absolute bare minimum of information to include in it. :-)

Sunlitspace542 commented 4 days ago

The footage is of Star Fox Next Gen, I am on the development team. This one has the worst case of it, though it does happen a bit on the title screen of Star Fox EX.

mrehkopf commented 4 days ago

Oh, totally missed that fact ^^; The in-game hook is also a possible cause for problems. I am not aware of any issues with Star Fox, however that may or may not be true for ROM hacks depending on the modifications made...

Sunlitspace542 commented 4 days ago

I don't have in-game hooks enabled either. I also haven't been able to reproduce it on any particularly accurate emulators.

Sunlitspace542 commented 4 days ago

I just tried enabling in-game hooks and the flickering is gone, at least in the part of the game I showed in the video. Booting over USB fixes all flickering issues. I enabled in-game hooks, and the associated options "in-game buttons" and "initial holdoff" are disabled. All other in-game settings are disabled. This doesn't appear to fix the title screen flicker in Star Fox EX I mentioned previously, but it does for this particular hack.

mrehkopf commented 4 days ago

Is there a patch available publicly? I'd like to check it out. (Though I'll be gone over the weekend) I assume that it doesn't happen on a vanilla ROM? (It doesn't for me)

Sunlitspace542 commented 4 days ago

It's still in very early development at the moment. I haven't had it happen with vanilla Star Fox or Star Fox 2.

Sunlitspace542 commented 4 days ago

Anyway though, as I said enabling in-game hooks is only a partial fix, as it only fixes flicker in the part I showed in the video. Booting over USB eliminates all flicker.

mrehkopf commented 4 days ago

Right now I am leaning towards the issue being a "real hardware" issue rather than an sd2snes/FXPAK issue, with the in-game hook being able to mask it somehow (it has an impact on NMI execution timing). Why it works via USB remains a mystery. Do you have a chance to test it on a SuperFX donor cart with EEPROM/Flash attached?

Sunlitspace542 commented 4 days ago

Do you have a chance to test it on a SuperFX donor cart with EEPROM/Flash attached?

I don't, but I know someone who can.

Ramsis-SNES commented 4 days ago

Just for the record, I tried StarFox EX v1.04.3 (both the normal and the FastROM patch) with my sd2snes Mk. II rev. H, firmware v1.11.0/issue186 on an Analogue Super Nt, and there are no glitches/flickering on either the intro sequence or the title screen whatsoever.

Also, I do own a homebrew GSU-2 flash cartridge, but programming the thing is rather tedious, so ... yeah.

multi-fx-06

multi-fx-07

multi-fx-08

multi-fx-09

Sunlitspace542 commented 3 days ago

I tried SFEX 1.10.04 (current public release) and it flickers on the title screen. it's not very frequent though, so it can be easily missed.

Sunlitspace542 commented 18 hours ago

Right now I am leaning towards the issue being a "real hardware" issue rather than an sd2snes/FXPAK issue, with the in-game hook being able to mask it somehow (it has an impact on NMI execution timing). Why it works via USB remains a mystery. Do you have a chance to test it on a SuperFX donor cart with EEPROM/Flash attached?

I just got the video back for the hardware test, no flickering at all.

https://github.com/user-attachments/assets/ca0bc7fd-758c-4d80-ae8c-ac2c77b0072f

Ramsis-SNES commented 15 hours ago

I was able to reproduce the flickering on the title screen of SFEX 1.10.04 tonight. The only thing I changed from the setup mentioned in my previous post was to use a real (2-PPU) PAL SNES (SuperCIC-modded, 60 Hz) hooked up to my Sony PVM-14M2E.

The flickering only appeared after power-cycling and reloading the ROM twice, though. Also, it was extremely sporadic. From the looks of it, it could very well be an issue of the hack itself. (It shows garbled graphics for a split second right at the start, even before the kandowontu message, so it doesn't seem to be too polished as of yet.)

I might consider writing the ROM to my GSU-2 flash cart (sigh) to really get to the bottom of this ...