search

mreichelt / docker-android

Docker images for Android development
MIT License
74 stars 11 forks source link

fix #7: add minimal circle ci config, should be placed in `.circleci/config.yml` #13

Closed NemoOudeis closed 5 years ago

NemoOudeis commented 5 years ago

working sample over here: https://circleci.com/gh/rakutentech/android-manifest-config/6

I didn't look into your docker files in detail, but what are the advantage of using those over the e.g. the circleci/android images (src here )? I noticed that the circle provide images spin up way fast on circle ci, while the mreichelt/android:28 one took 22 seconds to spin up... which is no surprise, they optimize for their own images 😂

mreichelt commented 5 years ago

Merged! Thanks a lot for contributing @NemoOudeis :-)

As for the difference between these docker images vs. the CircleCI ones: My Android docker images have been around for a longer time than the one by CircleCI. So at that time I created this the CircleCI images didn't exist yet, and other Docker images used older versions of the Android SDK manager - so I decided to start my own! Also I needed it for running Android tests on GitLab CI, which was not really possible with any other Docker image I researched at that time.

I'll check what actual differences there are and how we could improve my mreichelt/android images with it.

As for the performance on CircleCI, I'm pretty sure they cache their own Docker images on their own machines, which of course would give them a headstart. 😉